Skip to content

Radio QOL and bug fixes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2024
Merged

Radio QOL and bug fixes #55

merged 5 commits into from
Nov 13, 2024

Conversation

@mbiddle
Copy link
Contributor

@mbiddle mbiddle commented Nov 13, 2024

This PR brings multiple QOL and bug fixes.

  1. Added channel decimal rounding to two digits. It's odd that people can currently enter 499.9999999999 for channel numbers for example. This also fixes a strange use case when using the radio increase/decrease buttons that would also cause the channel to round oddly. The screenshots below was when I manually navigated to 16.1, then spammed the radio channel increase button multiple times, then spammed the radio channel decrease button to get below 15.1 to start seeing the issue.
  2. Fixed an inconsistency between being able to manually navigate to 0.1, but being unable to manually navigate to 1.1 and then clicking the channel down arrow.
  3. Fixed an issue where canaccess was being overwritten in joinRadio.
  4. Added a missing condition between the radio increase/decrease buttons.

Screenshot 2024-11-12 234441
Screenshot 2024-11-12 161316

bug fixes related to integer rounding issues when using the

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all its functionality? yes
  • Does your code fit the style guidelines? yes
  • Does your PR fit the contribution guidelines? yes

@mbiddle
Duplicated the initial onRadio condition from the decreaseradiochanne…
32e9d9b 
…l to the increaseradiochannel
@mbiddle
Fixed an issue where canaccess is being overwritten due to a missing …
09f0da3 
…return in joinRadio
@mbiddle
Updated the newChannel condition in decreaseradiochannel to be more c…
9cc3b29 
…onsistent with other places. You are able to navigate to 0.1 with the text input field, so you should be able to click the down arrow from 1.1 to 0.1.
@mbiddle
Added a rounding function to limit channels to two decimal points. Th…
7641cce 
…is also solves a use-case bug when navigating with the up/down arrows when your frequency has a decimal.
@mbiddle
This check is not needed as it's already handled in the connecttoradi…
db1a4e0 
…o function. This will also now allow the alert to show if you try to use the down arrow to go less than or equal to 0
Cocodrulo
Cocodrulo approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Cocodrulo Cocodrulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems good to me, great work!

@GhzGarage GhzGarage merged commit 5bb071e into qbcore-framework:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qwerty1Verified Qwerty1Verified Qwerty1Verified approved these changes

+1 more reviewer

@Cocodrulo Cocodrulo Cocodrulo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mbiddle mbiddle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbiddle @Qwerty1Verified @Cocodrulo @GhzGarage